Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible Lint issue #52

Closed
ghost opened this issue Jan 2, 2019 · 4 comments
Closed

Ansible Lint issue #52

ghost opened this issue Jan 2, 2019 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 2, 2019

getLines(string, "([^:]*):(\\d+)?:?(\\d*)?:? \\[?(\\D)(\\d*)\\]? (.*)");

https://github.com/jenkinsci/violation-comments-to-stash-plugin
The regex here appears to be excluding ansible lint formatting that is specified in the readme table. While its close to the FLAKE8 format this regex appears to only be looking for one letter then the number code for the error code. Ansible formats it as EANSIBLE.

some/script.yml:25: [EANSIBLE0012] Commands should not change things if nothing needs doing

Would suggest updating regex to be:
([^:]):(\d+)?:?(\d)?:? \[?(\D)+(\d*)\]? (.*)

@tomasbjerre
Copy link
Owner

Do you have an example report to use for testing?

@tomasbjerre tomasbjerre added the bug label Jan 2, 2019
@ghost
Copy link
Author

ghost commented Jan 2, 2019

Weblogic/playbooks/getDSdetails.yml:25: [EANSIBLE0012] Commands should not change things if nothing needs doing
Weblogic/playbooks/getDSdetails.yml:25: [EANSIBLE0013] Use shell only when shell functionality is required
Weblogic/playbooks/getDSdetails.yml:29: [EANSIBLE0012] Commands should not change things if nothing needs doing
Weblogic/playbooks/testDataSource.yml:24: [EANSIBLE0002] Trailing whitespace
Weblogic/playbooks/testDataSource.yml:25: [EANSIBLE0012] Commands should not change things if nothing needs doing
Weblogic/playbooks/testDataSource.yml:25: [EANSIBLE0013] Use shell only when shell functionality is required
Weblogic/playbooks/testDataSource.yml:28: [EANSIBLE0012] Commands should not change things if nothing needs doing

tomasbjerre added a commit that referenced this issue Jan 2, 2019
tomasbjerre added a commit that referenced this issue Jan 2, 2019
@tomasbjerre
Copy link
Owner

Released a fix now. In version 1.94 of the Jenkins plugin. Available from the update center within a few hours.

@ghost
Copy link
Author

ghost commented Jan 3, 2019

Worked! Thanks for updating it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant