Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't CodeNarc-Parsing respect SourceDirectory-Element #53

Closed
foto-andreas opened this issue Jan 8, 2019 · 5 comments
Closed

Shouldn't CodeNarc-Parsing respect SourceDirectory-Element #53

foto-andreas opened this issue Jan 8, 2019 · 5 comments
Labels

Comments

@foto-andreas
Copy link

On the CodeNarc Website there is an example file CodeNarc-Example which includes the Element "SourceDirectory", which is filled by CodeNarc. The "path" attribute is not filled. The current implementation of CodeNarcParser here respects only the path-attribute but ignores the "SourceDirectory". In our multi project builds using gradle this results in source files not being found.

I would suggest to prepend the path + name with the text-content of SourceDirectory.

@foto-andreas
Copy link
Author

Wow @tomasbjerre - remarkable timeframe für your reaction! :-) Thanks

@tomasbjerre
Copy link
Owner

Seems to be some problems with Maven Central and Bintray right now but I'll release it soon.

@tomasbjerre
Copy link
Owner

released now

@foto-andreas
Copy link
Author

foto-andreas commented Jan 14, 2019

problem: the slash after source directory should only be added if the source directory is not empty

                    .setFile(
                        (sourceDirectory
                                + (sourceDirectory.isEmpty() ? "" : "/")
                                + path
                                + "/"
                                + name)

@tomasbjerre
Copy link
Owner

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants