-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't CodeNarc-Parsing respect SourceDirectory-Element #53
Labels
Comments
tomasbjerre
added a commit
that referenced
this issue
Jan 8, 2019
Wow @tomasbjerre - remarkable timeframe für your reaction! :-) Thanks |
Seems to be some problems with Maven Central and Bintray right now but I'll release it soon. |
released now |
problem: the slash after source directory should only be added if the source directory is not empty
|
tomasbjerre
added a commit
that referenced
this issue
Jan 14, 2019
Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On the CodeNarc Website there is an example file CodeNarc-Example which includes the Element "SourceDirectory", which is filled by CodeNarc. The "path" attribute is not filled. The current implementation of CodeNarcParser here respects only the path-attribute but ignores the "SourceDirectory". In our multi project builds using gradle this results in source files not being found.
I would suggest to prepend the path + name with the text-content of SourceDirectory.
The text was updated successfully, but these errors were encountered: