Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting CPPCheckParser parser #101 #110

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

tomasbjerre
Copy link
Owner

No description provided.

@@ -4,13 +4,3 @@
<errors>
</errors>
</results>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uhafner
I want to support only parsing content of files. Not parsing a build log file.

Mixing content, like in a build log file, introduces problems that I don't want to solve. I think it is a fair requirement to put on the users, to supply valid XML.

With this change, the CPPCheck output has to be a valid XML. This file will not be parsable anymore with this PR:
https://github.com/tomasbjerre/violations-lib/blob/1.130/src/test/resources/cppcheck/self_closing_scope_limited.xml

What do you think? How will that affect your plugins?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to support only valid XML files. I have this restriction on many other parsers as well. So I don't think that this will break anything.

@tomasbjerre tomasbjerre merged commit c18fc63 into master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants