Fix CLI entry point #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "console scripts" entry points must point to a function in an installed python module.
tomocupy_cli:mainwas not a python module, it was a script located in /bin, so it is not a valid entry point. Pip creates a bash/cmd script (depends on the platform) that wraps the function listed in "console scripts" and installs it.The files listed in "scripts" are copied directly to the /bin folder, so they are not cross-platform because Windows and Unix handle scripts in different ways.
In this PR, I have moved the tomocupy_cli script into the the tomocupy package, so it is installed with the rest of the module and now the console_scripts entry point points to a function that actually exists.