Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebase upgrade #229

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Codebase upgrade #229

merged 1 commit into from
Jul 10, 2019

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Jul 10, 2019

This is a very large pull request that includes the upgrade to latest dependency versions and fixes suggested by Clippy.

tomusdrw
tomusdrw reviewed Jul 10, 2019
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Wow, amazing! Thank you!

Looks good, only tiny grumble regarding version strings and we can merge it.

Cargo.toml Outdated Show resolved Hide resolved
@tomusdrw tomusdrw merged commit f043b22 into tomusdrw:master Jul 10, 2019
@vorot93 vorot93 deleted the upgrade branch July 10, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vorot93 @tomusdrw