Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ton v13 #182

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Upgrade to ton v13 #182

merged 6 commits into from
Jul 19, 2023

Conversation

hrmon
Copy link
Contributor

@hrmon hrmon commented Jun 30, 2023

No description provided.

}
});
}
return parsedItems;
}

export async function makeGetCall<T>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need makeGetCall anywhere in this codebase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for calling get methods on submitted contracts (Getters component)

Comment on lines 12 to 13
const verifiedAddressStr = verifiedAddress?.toString() ?? null;
const verifiedAddresssHex = verifiedAddress?.toString() ?? null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks suspicious - if we wanted one friendly representation (EQDerEP...) and one hex (0:deac43d3221d0e...) we need different calls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, toString is now toRawString in ton v13. Fixed it.

Copy link
Collaborator

@shaharyakir shaharyakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, looks generally good, I will test functionality meanwhile.

return ["tvm.Slice", p.toBoc({ idx: false }).toString("base64")];
} else if (p instanceof BN) {
return ["num", p.toString(10)];
paramsTuple.writeCell(p);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be writeSlice

}

throw new Error("unknown type!");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this always gets called

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs addressing after latest fixes (e.g. put in else clause)

case "list":
if (val.elements.length === 0) {
return null;
parsedItems.push((item as TupleItemCell).cell);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing break in these switches

Copy link
Collaborator

@shaharyakir shaharyakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also make sure all toNano(..) are replaced with string params

@EmelyanenkoK EmelyanenkoK merged commit cf81c42 into ton-blockchain:main Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants