-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ton v13 #182
Upgrade to ton v13 #182
Conversation
} | ||
}); | ||
} | ||
return parsedItems; | ||
} | ||
|
||
export async function makeGetCall<T>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need makeGetCall anywhere in this codebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for calling get methods on submitted contracts (Getters
component)
src/lib/useContractAddress.ts
Outdated
const verifiedAddressStr = verifiedAddress?.toString() ?? null; | ||
const verifiedAddresssHex = verifiedAddress?.toString() ?? null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks suspicious - if we wanted one friendly representation (EQDerEP...) and one hex (0:deac43d3221d0e...) we need different calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, toString
is now toRawString
in ton v13. Fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, looks generally good, I will test functionality meanwhile.
src/lib/makeGetCall.ts
Outdated
return ["tvm.Slice", p.toBoc({ idx: false }).toString("base64")]; | ||
} else if (p instanceof BN) { | ||
return ["num", p.toString(10)]; | ||
paramsTuple.writeCell(p); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be writeSlice
src/lib/makeGetCall.ts
Outdated
} | ||
|
||
throw new Error("unknown type!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this always gets called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs addressing after latest fixes (e.g. put in else clause)
case "list": | ||
if (val.elements.length === 0) { | ||
return null; | ||
parsedItems.push((item as TupleItemCell).cell); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing break in these switches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also make sure all toNano(..)
are replaced with string params
No description provided.