FunC v0.5.0 logic and dependencies updates #212
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tree-sitter-func.wasm copied from vscode with v0.5.0 support * getterParser modified to support `get` keyword * updated sdk dep * added v0.5.0 dep from func-js-bin
shaharyakir
reviewed
Jun 24, 2024
| @@ -35,6 +35,8 @@ | |||
| "func-js-bin-0.4.2": "npm:@ton-community/func-js-bin@^0.4.2", | |||
| "func-js-bin-0.4.3": "npm:@ton-community/func-js-bin@^0.4.3", | |||
| "func-js-bin-0.4.4": "npm:@ton-community/func-js-bin@^0.4.4", | |||
| "func-js-bin-0.5.0": "npm:@ton-community/func-js-bin@^0.5.0", | |||
| "highlight.js": "^11.6.0", | |||
There was a problem hiding this comment.
the reason highlight.js wasn't included so far is because contract-verifier-sdk has it with it. just otherwise there may be a version discrepancy which is the downside with this approach.
This comment was marked as spam.
This comment was marked as spam.
johndpierre1
approved these changes
Jul 10, 2024
Aho38wkw
approved these changes
Jul 28, 2024
Aho38wkw
approved these changes
Jul 28, 2024
This comment was marked as spam.
This comment was marked as spam.
Aho38wkw
approved these changes
Jul 30, 2024
Aho38wkw
approved these changes
Jul 30, 2024
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since FunC v0.5.0 introduces new keywords and new syntax for get methods, contracts written in v0.5.0+ should be correctly parsed and highlighted in TON verifier.
Highlighing is implemented in ton-community/contract-verifier-sdk#324, so we just need to update the dependency.
To parse sources,
tree-sitter-func.wasmis copied (surprisingly) from VS Code plugin, implemented here.The file
getterParser.tscontains logic for AST traversing, also modified by this MR (supports bothmethod_idfrom v0.4.x andgetfrom v0.5.0).