Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for clear_meta and expanded has_meta in DataDictBase. #271

Conversation

pfafflabatuiuc
Copy link
Contributor

Fixed bug for clear_meta() in DataDictBase: when specifying a data field to clear the meta from, it was deleting it while iterating the array so it was crashing.

Expanded has_meta() so it can look in the meta data of data fields.

Added both things to the testing of meta data

Copy link
Contributor

@wpfff wpfff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@wpfff wpfff merged commit d7d1f09 into toolsforexperiments:master Mar 29, 2022
@pfafflabatuiuc pfafflabatuiuc deleted the delete_meta_bugfix&has_meta_expansion branch March 29, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants