Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Enterprise support #5

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Add GitHub Enterprise support #5

merged 1 commit into from
Apr 26, 2024

Conversation

tynsh
Copy link
Contributor

@tynsh tynsh commented Apr 24, 2024

This PR adds support for GitHub Enterprise and fixes a minor issue with yq. I was only able to test this on one GitHub Enterprise instance I have access too. But the docs are quite clear, so I assume this will work for others as well.

I have not tested if the code works for public github, which is something someone needs to do :) . I currently don't have a project set up with workflows there.

Copy link
Owner

@topaxi topaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you 😊

Some small comments below, then we are good to go!

I quickly tested it with this repo here, and everything seems to work for public repos 👍

lua/gh-actions/github.lua Outdated Show resolved Hide resolved
lua/gh-actions/github.lua Outdated Show resolved Hide resolved
lua/gh-actions/github.lua Outdated Show resolved Hide resolved
@tynsh
Copy link
Contributor Author

tynsh commented Apr 25, 2024

Thanks for the review! Glad to help :)

@topaxi
Copy link
Owner

topaxi commented Apr 26, 2024

Great work, thank you! 😊

@topaxi topaxi enabled auto-merge (squash) April 26, 2024 07:55
@topaxi topaxi merged commit ec39248 into topaxi:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants