Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVGs should be compressed #320

Closed
casey opened this issue Jan 16, 2023 · 2 comments · Fixed by #321
Closed

SVGs should be compressed #320

casey opened this issue Jan 16, 2023 · 2 comments · Fixed by #321
Labels
C-bug Category: This is a bug. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@casey
Copy link
Contributor

casey commented Jan 16, 2023

I noticed that by default, all content types starting with image/ are not compressed. However, SVGs are text and would thus benefit from compression, but have content type image/svg+xml. Ideally, SVGs should be excepted and compressed.
@davidpdrsn davidpdrsn added C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. E-easy Call for participation: Experience needed to fix: Easy / not much labels Jan 16, 2023
@davidpdrsn
Copy link
Member

That makes sense! Should be pretty easy to fix. Just have to add a check for svg here

davidpdrsn added a commit that referenced this issue Jan 20, 2023
@davidpdrsn
Still compress svgs
641fcda 
Even though they're images they're really just xml, so should still be
compressed.

Fixes #320
@davidpdrsn davidpdrsn mentioned this issue Jan 20, 2023
Merged
davidpdrsn added a commit that referenced this issue Jan 20, 2023
@davidpdrsn
Do compress SVGs (#321)
e941dee 
* Still compress svgs

Even though they're images they're really just xml, so should still be
compressed.

Fixes #320

* changelog
@casey
Copy link
Contributor Author

casey commented Jan 21, 2023

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do compress SVGs tower-rs/tower-http
2 participants
@casey @davidpdrsn