Impl Default
for CompressionBody
when possible
#323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows interop with
tonic::transport::Server
andtonic::transport::server::Router::serve_with_shutdown
which require that the responses implementDefault
.EDIT: It turns out that this
Default
requirement was actually coming fromCorsMiddleware
from this crate.I was able to work around this by switching the order of the middleware to put
CompressionLayer
beforeCorsLayer
. It's up to you all if you still want to merge this, but yeah.Motivation
When trying to use
CompressionLayer
in atonic::transport::Server
, I was unable to due to missingDefault
implementation on theCompressionBody
.Solution
This implements a trivial
Default
forCompressionBody
when the innerBody
also implementsDefault
.