Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade base64 and brotli #499

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Upgrade base64 and brotli #499

merged 1 commit into from
Jul 31, 2024

Conversation

xmakro
Copy link
Contributor

@xmakro xmakro commented Jul 22, 2024

No description provided.

@nyurik
Copy link

nyurik commented Jul 31, 2024

Friendly ping to @davidpdrsn and @jplatte - Brotli dep before 6 has some conflicts with prior versions, please merge and release when you have a sec. Thx :)

@jplatte jplatte self-assigned this Jul 31, 2024
@jplatte
Copy link
Collaborator

jplatte commented Jul 31, 2024

What do you mean regarding conflicts? The brotli dep being upgraded here is just a dev-dependency (and base64 is not part of the public API). I'll merge anyways, but not sure when it will be released.

@jplatte jplatte merged commit 24b6b73 into tower-rs:main Jul 31, 2024
11 checks passed
@nyurik
Copy link

nyurik commented Jul 31, 2024

thx! I guess it is not that big of a deal with dev dependency, although it could still fail: if some of your dependencies use brotli internally, and they use a different version, cargo will try to build with both brotli versions together - which will fail because brotli uses FFI and makes them public - so linker would see a conflict of two different functions being exported under the same name. Brotli v6 does not automatically publish ffi, so it is pure rust only, and won't conflict with previous version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants