util: Two call_all bug fixes #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
force-pushed
the
call-all-bug-fixes
branch
from
e8c461a
to
3ee139a
Compare
One is handling poll_ready errors (tower-rs#706). The other is fixing the TODO about disarming poll_ready, since there is no disarm this makes sure `poll_ready` is only called if `call` will immediately follow.
leoyvens
force-pushed
the
call-all-bug-fixes
branch
from
3ee139a
to
6ea1d23
Compare
LucioFranco
approved these changes
Nov 1, 2022
|
@LucioFranco Thank you for the review! Fast as a 🥷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One is handling poll_ready errors, resolves #706.
The other is fixing the TODO about disarming poll_ready, since there is no disarm this makes sure
poll_readyis only called ifcallwill immediately follow. This one actually hit me in production.Each bug fix has a corresponding test case. This should not be breaking any public API.