Double backslash #1710
Closed
Double backslash #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
jayvdb
commented
Oct 22, 2020
| (?::(?P<default_value>[^{}]*))? # default value | ||
| [}] | ||
| (?::(?P<default_value>([^{}]|\\{|\\})*))? # default value | ||
| (?<!\\)[}] |
There was a problem hiding this comment.
This should really be (?<![^\\]\\)[}] , but that introduces problems that I believe can only be solved if \ is not permitted in section headings or in key names, or possibly only the last character of those strings.
jayvdb
force-pushed
the
double-backslash
branch
from
f813e7c
to
74bd990
Compare
gaborbernat
requested changes
Oct 24, 2020
|
I'll close this for now until you can attend to the PR again. Once you've done we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape backslash.
Fixes #1708
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)