Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suport # character in path of tox project #2146

Merged
merged 2 commits into from
Aug 8, 2021

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Aug 8, 2021

Resolves #763.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat added this to the 4.0 milestone Aug 8, 2021
@gaborbernat gaborbernat added the bug:normal affects many people or has quite an impact label Aug 8, 2021
@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #2146 (af256fe) into rewrite (174fd08) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           rewrite    #2146   +/-   ##
========================================
  Coverage    99.85%   99.85%           
========================================
  Files          157      157           
  Lines         8767     8786   +19     
  Branches       918      920    +2     
========================================
+ Hits          8754     8773   +19     
  Misses           3        3           
  Partials        10       10           
Flag Coverage Δ
tests 99.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tox/config/loader/ini/__init__.py 100.00% <100.00%> (ø)
src/tox/config/loader/ini/replace.py 100.00% <100.00%> (ø)
src/tox/config/loader/str_convert.py 100.00% <100.00%> (ø)
src/tox/config/set_env.py 100.00% <100.00%> (ø)
src/tox/pytest.py 100.00% <100.00%> (ø)
tests/session/cmd/test_show_config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174fd08...af256fe. Read the comment docs.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat merged commit b92bc5b into tox-dev:rewrite Aug 8, 2021
Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am late to the party, but changes look good. Thanks!

@gaborbernat gaborbernat deleted the 763 branch August 10, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided bug:normal affects many people or has quite an impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants