Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AD via Zygote (WIP). #24

Closed
wants to merge 3 commits into from
Closed

Support AD via Zygote (WIP). #24

wants to merge 3 commits into from

Conversation

tpapp
Copy link
Owner

@tpapp tpapp commented Dec 19, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #24 into master will increase coverage by 4.81%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24      +/-   ##
=======================================
+ Coverage   85.18%   90%   +4.81%     
=======================================
  Files           4     5       +1     
  Lines          81    90       +9     
=======================================
+ Hits           69    81      +12     
+ Misses         12     9       -3
Impacted Files Coverage Δ
src/LogDensityProblems.jl 97.87% <100%> (+8.74%) ⬆️
src/AD_Zygote.jl 25% <25%> (ø)
src/AD_ReverseDiff.jl 100% <0%> (+12.5%) ⬆️
src/AD_Flux.jl 85.71% <0%> (+14.28%) ⬆️
src/AD_ForwardDiff.jl 95% <0%> (+15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d2b81b...be45023. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 102

  • 3 of 9 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.1%) to 89.888%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/AD_Zygote.jl 2 8 25.0%
Totals Coverage Status
Change from base Build 96: 6.1%
Covered Lines: 80
Relevant Lines: 89

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 102

  • 3 of 9 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.1%) to 89.888%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/AD_Zygote.jl 2 8 25.0%
Totals Coverage Status
Change from base Build 96: 6.1%
Covered Lines: 80
Relevant Lines: 89

💛 - Coveralls

@tpapp
Copy link
Owner Author

tpapp commented Mar 5, 2019

PR should be dusted off for new API, or rewritten from scratch.

@tpapp
Copy link
Owner Author

tpapp commented Mar 10, 2019

Closing in favor of #40.

@tpapp tpapp closed this Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants