Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New learning rate schedulers #1481

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

rubenjr0
Copy link
Contributor

@rubenjr0 rubenjr0 commented Mar 17, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1198

Changes

  • Implementation of an Exponential learning rate scheduler
  • Implementation of a Cosine Annealing learning rate scheduler with cold restarts

Testing

New unit tests following the same structure as the previously implemented schedulers' tests have been implemented.

@rubenjr0
Copy link
Contributor Author

rubenjr0 commented Mar 17, 2024

The run-checks all script sometimes fails because of #1478

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 78.39506% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 85.76%. Comparing base (41d01b8) to head (507f948).

Files Patch % Lines
crates/burn-core/src/lr_scheduler/cosine.rs 76.00% 24 Missing ⚠️
crates/burn-core/src/lr_scheduler/exponential.rs 82.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   85.77%   85.76%   -0.02%     
==========================================
  Files         649      651       +2     
  Lines       72416    72578     +162     
==========================================
+ Hits        62117    62244     +127     
- Misses      10299    10334      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these additions. Looks great to me.

Waiting for one more reviewer.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution 🙂

@antimora antimora merged commit 69f1877 into tracel-ai:main Mar 19, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants