Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nft json files with names, descriptions and attributes #5

Merged
merged 22 commits into from
Sep 14, 2024

Conversation

kehindave
Copy link
Contributor

No description provided.

@mezrin
Copy link
Contributor

mezrin commented Sep 12, 2024

Checked the data.
Several fixes are needed

  • top-level fields were updated: metadata_id, title, description. These changes needs to be reverted. We need to update only these fields: traits -> named -> name, tech.trait.wallet.nft_token_description -> nft_token_description, tech.trait.wallet.nft_token_attributes -> attributes

  • there is a new field "isModified": true. It shouldn't exist, need to delete it

  • would be great to create a longer description for each NFT. I mean the field tech.trait.wallet.nft_token_description -> nft_token_description. At the moment it's about 70 symbols. I think 250-300 symbols would be better

All the rest is fine

@kehindave
Copy link
Contributor Author

Updated the data and added a basic python script for using openAI API

@mezrin
Copy link
Contributor

mezrin commented Sep 13, 2024

  • we still have some unwanted changes in many files - in IDs and tech comments. Need to revert it
Screenshot 2024-09-13 at 10 45 11

@kehindave
Copy link
Contributor Author

@mezrin Please check again

@mezrin mezrin merged commit cc7e8cc into add-assets Sep 14, 2024
@mezrin mezrin deleted the gpt-descriptions branch September 14, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants