Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AP-680] Fastsync tables with composite primary key #400

Merged
merged 6 commits into from
May 6, 2020
Merged

Conversation

koszti
Copy link
Contributor

@koszti koszti commented May 5, 2020

Description

CREATE TABLE statements not generated correctly by fastsync if table has composite key. The only reason why fastsync is still working with tables with composite PKs is that Snowflake and Redshift don't enforce primary keys.

Fixing it to generate DDLs with composite PKs correctly.

Checklist

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] if applicable. AP-NNNN = JIRA ID
  • Branch name starts with AP-NNN if applicable. AP-NNN = JIRA ID
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@koszti koszti merged commit 705afbf into master May 6, 2020
@koszti koszti deleted the AP-680 branch May 6, 2020 08:58
tibortezsla pushed a commit to tibortezsla/pipelinewise that referenced this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants