Add Google Analytics tap #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we merged some new items recently and caused some conflicts. can you please fix them? |
|
Done, rebased. |
koszti
approved these changes
May 29, 2020
|
merged, but found a dependency incompatibility error when installing everything together. Problem fixed by transferwise/pipelinewise-tap-google-analytics#6 and tap-ga connector should be pinned to the new version soon. |
tibortezsla
pushed a commit
to tibortezsla/pipelinewise
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #267 rebased against upstream and includes 1.1.0 version of pipelinewise-tap-google-analytics.
Checklist
setup.pyis an individual PR and not mixed with feature or bugfix PRs[AP-NNNN]if applicable. AP-NNNN = JIRA IDAP-NNNif applicable. AP-NNN = JIRA ID