feat(lib): make lib no_std #3395
Open
+114
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that regex does support |
|
yes, I add regex to no_std. But as a trade-off, regex itself is removed from the workspace. Because |
|
There are more features that need to be toggled, and I also see this note now (though it could just be outdated), so maybe regex should just be disabled in |
|
that note is outdated. I test this pr for --target=thumbv7m-none-eabi, and this passed. |
|
You should also add a note to the rust binding readme. |
cathaysia
force-pushed
the
feature/no_std
branch
2 times, most recently
from
2d0b73c
to
98dc0c2
Compare
close tree-sitter#3391 Signed-off-by: DragonBillow <DragonBillow@outlook.com> Update lib/Cargo.toml Co-authored-by: ObserverOfTime <chronobserver@disroot.org> Update lib/Cargo.toml Co-authored-by: ObserverOfTime <chronobserver@disroot.org>
cathaysia
force-pushed
the
feature/no_std
branch
from
98dc0c2
to
f27c81f
Compare
|
this pr should ready be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3391