Add rain-terraces (trapping rain water) algorithm #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KeoniGarner thank you for your PR. It looks like the code has linting issues. Could you please fix them so that tests are passed? You may lint code by running |
|
Thank you for the quick response! I think that should take care of the linting. |
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 115 116 +1
Lines 2258 2280 +22
Branches 394 399 +5
=====================================
+ Hits 2258 2280 +22
Continue to review full report at Codecov.
|
|
Thank you for contribution @KeoniGarner |
shoredata
pushed a commit
to shoredata/javascript-algorithms
that referenced
this pull request
Mar 28, 2019
* Add rain-terraces (trapping rain water) algorithm * Fixed linting errors * Fixed linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should probably be a basic/beginner algorithm