Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka schema prefix #2351

Merged
merged 10 commits into from
Oct 10, 2023
Merged

Kafka schema prefix #2351

merged 10 commits into from
Oct 10, 2023

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Sep 28, 2023

Pull request

Description

Allow schema prefixes to be handled via a pre-processor

Related

  • RFC
  • Related Issues: fixes #000, closed #000
  • Related docs PR

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2351 (a6616c0) into main (c15dda0) will increase coverage by 36.62%.
The diff coverage is 91.02%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2351       +/-   ##
===========================================
+ Coverage   54.32%   90.95%   +36.62%     
===========================================
  Files         264      279       +15     
  Lines       39255    59553    +20298     
===========================================
+ Hits        21325    54165    +32840     
+ Misses      17930     5388    -12542     
Flag Coverage Δ
unittests 90.95% <91.02%> (+36.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/config.rs 98.30% <100.00%> (+4.22%) ⬆️
src/connectors/impls/file.rs 91.79% <100.00%> (+2.05%) ⬆️
src/connectors/impls/gpubsub/producer.rs 98.06% <100.00%> (+94.81%) ⬆️
src/connectors/impls/http/client.rs 87.76% <100.00%> (+1.79%) ⬆️
src/connectors/impls/kafka/producer.rs 87.27% <100.00%> (+5.00%) ⬆️
src/connectors/impls/otel/logs.rs 97.90% <ø> (+39.69%) ⬆️
src/connectors/impls/otel/metrics.rs 97.63% <ø> (+81.04%) ⬆️
src/connectors/impls/otel/trace.rs 100.00% <ø> (+13.84%) ⬆️
src/connectors/impls/stdio.rs 95.71% <100.00%> (+0.88%) ⬆️
src/connectors/impls/tcp/client.rs 95.16% <100.00%> (+3.86%) ⬆️
... and 51 more

... and 182 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15dda0...a6616c0. Read the comment docs.

@Licenser Licenser force-pushed the kafka-schema-prefix branch 8 times, most recently from 05ecb85 to ca2355d Compare October 6, 2023 09:53
@Licenser Licenser marked this pull request as ready for review October 6, 2023 10:04
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor typoes and small nitpicks. Otherwise looks good to go.

tremor-codec/src/codec/json.rs Outdated Show resolved Hide resolved
src/connectors/source.rs Show resolved Hide resolved
src/preprocessor.rs Outdated Show resolved Hide resolved
src/preprocessor/kafka_schema_registry_prefix.rs Outdated Show resolved Hide resolved
src/preprocessor/kafka_schema_registry_prefix.rs Outdated Show resolved Hide resolved
tremor-codec/src/codec/avro.rs Show resolved Hide resolved
mfelsche
mfelsche previously approved these changes Oct 9, 2023
Licenser and others added 10 commits October 9, 2023 13:17
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Co-authored-by: Matthias Wahl <mfelsche@users.noreply.github.com>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser merged commit b27e0c5 into main Oct 10, 2023
18 checks passed
@Licenser Licenser deleted the kafka-schema-prefix branch October 10, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants