Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kafka SmolRuntime hang, fixes #532 #558

Merged
merged 4 commits into from
Nov 4, 2020
Merged

Fix Kafka SmolRuntime hang, fixes #532 #558

merged 4 commits into from
Nov 4, 2020

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Nov 3, 2020

Pull request

Fix hang on kafka producer

Description

This fixes a hang on the kafka producer when using queue.buffering.max.ms

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested (we currently can not test Kafka sinks/sources, manual tests will be done instead)
  • Use of unsafe code is reasoned about in a comment

@Licenser Licenser marked this pull request as draft November 3, 2020 16:54
@darach darach changed the title Fix kafka SmolRuntime hang, fixes #532 Fix Kafka SmolRuntime hang, fixes #532 Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #558 into main will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   80.09%   80.49%   +0.39%     
==========================================
  Files         102      101       -1     
  Lines       13864    13770      -94     
==========================================
- Hits        11105    11084      -21     
+ Misses       2759     2686      -73     
Impacted Files Coverage Δ
src/pipeline.rs 64.15% <100.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ffce4...bab5d9f. Read the comment docs.

@Licenser Licenser marked this pull request as ready for review November 3, 2020 17:25
@mfelsche
Copy link
Member

mfelsche commented Nov 3, 2020

Mr. @Licenser can you enlighten me on why this fixes the hangs we've seen? I am more than curious.

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@mfelsche
Copy link
Member

mfelsche commented Nov 4, 2020

I sneakily rebased on main

mfelsche
mfelsche previously approved these changes Nov 4, 2020
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on my machine. Good job!

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
mfelsche
mfelsche previously approved these changes Nov 4, 2020
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Licenser Licenser merged commit 562e006 into main Nov 4, 2020
@Licenser Licenser deleted the fix-smol-runtime branch November 4, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate kafka egress issue
3 participants