-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Kafka SmolRuntime hang, fixes #532 #558
Conversation
Codecov Report
@@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 80.09% 80.49% +0.39%
==========================================
Files 102 101 -1
Lines 13864 13770 -94
==========================================
- Hits 11105 11084 -21
+ Misses 2759 2686 -73
Continue to review full report at Codecov.
|
Mr. @Licenser can you enlighten me on why this fixes the hangs we've seen? I am more than curious. |
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
c9d3ad0
to
23f69d6
Compare
I sneakily rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on my machine. Good job!
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Pull request
Fix hang on kafka producer
Description
This fixes a hang on the kafka producer when using
queue.buffering.max.ms
Related
Checklist