Remove todo macro from tcp sink. #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
=======================================
Coverage 80.49% 80.49%
=======================================
Files 101 101
Lines 13770 13770
=======================================
Hits 11084 11084
Misses 2686 2686 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Wahl mwahl@wayfair.com
Pull request
Remove leftover
todo!()macro from TCP sink, rendering it unusable.Description
Remove leftover
todo!()macro from TCP sink, rendering it unusable.And add a check for todo! so it fails CI if this ever happens again.
Related
Checklist