Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translations: translate "processing.." strings coming from storage #3520

Closed
matejcik opened this issue Feb 6, 2024 · 0 comments · Fixed by #3610
Closed

translations: translate "processing.." strings coming from storage #3520

matejcik opened this issue Feb 6, 2024 · 0 comments · Fixed by #3610
Assignees
@matejcik
Labels
code Code improvements

Comments

@matejcik
Copy link
Contributor

matejcik commented Feb 6, 2024

storage.c has a bunch of baked-in English strings for progress labels.
these need to be translated too.

(similar case may be for wipe code erasure and similar)

the way to go seems to be to return an enum instead of literal string, and let the UI code convert to a string.

this can be done after #3206 is merged, to not block it anymore
@matejcik matejcik added the code Code improvements label Feb 6, 2024
@matejcik matejcik mentioned this issue Mar 13, 2024
Closed
matejcik added a commit that referenced this issue Mar 15, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
00f16f8 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 15, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
6f01f4c 
…ge translations

fixes #3520
@matejcik matejcik mentioned this issue Mar 15, 2024
Merged
matejcik added a commit that referenced this issue Mar 15, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
aae8b29 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 15, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
cb29467 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 15, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
d926821 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 21, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
080d0b8 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 22, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
9f0df50 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 25, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
02fa86a 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 25, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
3f05833 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 26, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
3584f77 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 28, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
b66b00e 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 30, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
7d3bdb5 
…ge translations

fixes #3520
matejcik added a commit that referenced this issue Mar 30, 2024
@matejcik
feat(core/ui): unify progress.py code between models, implement stora…
de2fe3d 
…ge translations

fixes #3520
M1nd3r pushed a commit that referenced this issue Apr 12, 2024
@matejcik @M1nd3r
feat(core/ui): unify progress.py code between models, implement stora…
c7ce7b8 
…ge translations

fixes #3520
onvej-sl pushed a commit that referenced this issue May 10, 2024
@matejcik @onvej-sl
feat(core/ui): unify progress.py code between models, implement stora…
72ca3e9 
…ge translations

fixes #3520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejcik matejcik

Labels
code Code improvements
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Translate strings coming from storage trezor/trezor-firmware
1 participant
@matejcik