-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T3B1: fix coin support info and translations generation #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matejcik
force-pushed
the
matejcik/coins-t3b1
branch
from
September 2, 2024 13:20
f08a333
to
599e465
Compare
builds on top of #4148 |
matejcik
force-pushed
the
matejcik/coins-t3b1-only
branch
from
September 3, 2024 08:34
205b4a0
to
2cb977e
Compare
matejcik
force-pushed
the
matejcik/coins-t3b1
branch
2 times, most recently
from
September 3, 2024 10:51
5009b34
to
fa00575
Compare
I wonder if we should build firmware images for both? At least nightly. UI tests don't seem very important. |
mmilata
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[no changelog]
matejcik
force-pushed
the
matejcik/coins-t3b1
branch
from
September 10, 2024 11:40
fa00575
to
76a2113
Compare
matejcik
added
the
translations
Put this label on a PR to run tests in all languages
label
Sep 10, 2024
complicated flows that _do not accomplish results_ do not belong into device_tests, so I moved them to click_tests and added stronger assert system
matejcik
force-pushed
the
matejcik/coins-t3b1
branch
2 times, most recently
from
September 11, 2024 08:41
75066d4
to
8d0cf6a
Compare
this includes D001 / D002, that probably doesn't matter
…github now that we don't really use gitlab anymore
matejcik
force-pushed
the
matejcik/coins-t3b1
branch
from
September 11, 2024 10:43
8d0cf6a
to
e90601b
Compare
matejcik
removed
the
translations
Put this label on a PR to run tests in all languages
label
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also flip CI to use T3B1 everywhere that we previously used T2B1.
to be discussed: do we also want to run T2B1 in some limited capacity?
(e.g., yes to UI tests, no to translations?)