Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: warn when Cargo.lock is edited, don't test 🇮🇹 #4158

Merged
merged 3 commits into from
Sep 13, 2024
Merged

ci: warn when Cargo.lock is edited, don't test 🇮🇹 #4158

merged 3 commits into from
Sep 13, 2024

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Sep 5, 2024 •
edited
Loading

Example comment below ⬇️, wording suggestions appreciated.

Also remove Italian from the language matrix for full CI pipeline (with translations PR label) as discussed with @Hannsek

@mmilata mmilata force-pushed the mmilata/ci branch 2 times, most recently from ad6fe42 to 6881a0e Compare September 5, 2024 17:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Looks like you changed Cargo.lock. Please make sure to review the dependencies and update internal version list.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@mmilata mmilata force-pushed the mmilata/ci branch 2 times, most recently from 127110a to 60b8cd8 Compare September 5, 2024 17:37
@mmilata mmilata changed the title ci: warn when Cargo.lock is edited ci: warn when Cargo.lock is edited, don't test 🇮🇹 Sep 5, 2024
@mmilata mmilata marked this pull request as ready for review September 5, 2024 17:57
@mmilata mmilata self-assigned this Sep 5, 2024
@matejcik matejcik requested review from obrusvit and removed request for matejcik September 12, 2024 12:06
obrusvit
obrusvit reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding two suggestions.

.github/workflows/prebuild.yml Outdated Show resolved Hide resolved
.github/workflows/prebuild.yml Show resolved Hide resolved
@mmilata
Copy link
Member Author

mmilata commented Sep 12, 2024

Also added fix for broken coverage reporting due to actions/upload-artifact#598

@mmilata mmilata merged commit 884d5b0 into main Sep 13, 2024
85 checks passed
@mmilata mmilata deleted the mmilata/ci branch September 13, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

Assignees

@mmilata mmilata

Labels
None yet
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmilata @obrusvit