chore(common): separate definitions of protobuf options #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M1nd3r
force-pushed
the
M1nd3r/protobuf-options
branch
9 times, most recently
from
163b117
to
1bf4588
Compare
M1nd3r
requested review from
mmilata and
andrewkozlik
and removed request for
andrewkozlik
M1nd3r
commented
Oct 16, 2024
| descriptor_proto = protoc(proto) | ||
| # The proto tuple is sorted to give consistent results in different environments | ||
| list_proto = list(proto) | ||
| list_proto.sort() |
There was a problem hiding this comment.
This is needed, because other environments (eg. my local system) can have different default sorting of files:
- On my system messages.proto are before messages-stellar.proto.
- In CI environment, the messages.proto are after messages-stellar.proto.
This leads to a different order of generated classes in messages.py (and the order of enums in other .py file). The change of order has no impact on functionality, but it is captured as "diff" during Prebuild Gen check resulting in check fail. Sorting the file names consistently using python sort prevents the issue.
[no changelog]
M1nd3r
force-pushed
the
M1nd3r/protobuf-options
branch
from
1bf4588
to
35da1dc
Compare
[no changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: remove dependency between "options" and enum
MessageType..protofiles should not depend onmessages.protowhen only "options" are needed.