Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer access control #4267

Draft
wants to merge 1 commit into
base: cepetr/platform-common-cleanup
Choose a base branch
from

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Oct 16, 2024

This small PR adds precise access control for the framebuffer (and resolves #4207).

This change is primarily aimed at devices using two framebuffers (T3T1) but also affects devices using a single framebuffer (T2B1, T3B1).

Before this change, the unprivileged app had access to both framebuffers at any time. Now, an unprivileged application has access only to the framebuffer acquired by display_get_frame_buffer() until it releases it by calling the display_refresh() function.

@cepetr cepetr added T2B1 Trezor Safe 3 T3T1 T3B1 labels Oct 16, 2024
@cepetr cepetr self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2B1 Trezor Safe 3 T3B1 T3T1
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

1 participant