Skip to content

Commit

Permalink
boa-dev#4009: eq bug fix + tests (boa-dev#4010)
Browse files Browse the repository at this point in the history
  • Loading branch information
Nikita-str authored Sep 28, 2024
1 parent 4ed2bad commit 628e31c
Showing 1 changed file with 40 additions and 9 deletions.
49 changes: 40 additions & 9 deletions core/engine/src/value/integer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,7 @@ impl PartialEq<i64> for IntegerOrInfinity {

impl PartialEq<IntegerOrInfinity> for i64 {
fn eq(&self, other: &IntegerOrInfinity) -> bool {
match other {
IntegerOrInfinity::Integer(i) => i == other,
_ => false,
}
other.eq(self)
}
}

Expand All @@ -93,10 +90,44 @@ impl PartialOrd<i64> for IntegerOrInfinity {

impl PartialOrd<IntegerOrInfinity> for i64 {
fn partial_cmp(&self, other: &IntegerOrInfinity) -> Option<Ordering> {
match other {
IntegerOrInfinity::PositiveInfinity => Some(Ordering::Less),
IntegerOrInfinity::Integer(i) => self.partial_cmp(i),
IntegerOrInfinity::NegativeInfinity => Some(Ordering::Greater),
}
other.partial_cmp(self).map(Ordering::reverse)
}
}

#[cfg(test)]
mod tests {
use super::*;

#[test]
fn test_eq() {
let int: i64 = 42;
let int_or_inf = IntegerOrInfinity::Integer(10);
assert!(int != int_or_inf);
assert!(int_or_inf != int);

let int: i64 = 10;
assert!(int == int_or_inf);
assert!(int_or_inf == int);
}

#[test]
fn test_ord() {
let int: i64 = 42;

let int_or_inf = IntegerOrInfinity::Integer(10);
assert!(int_or_inf < int);
assert!(int > int_or_inf);

let int_or_inf = IntegerOrInfinity::Integer(100);
assert!(int_or_inf > int);
assert!(int < int_or_inf);

let int_or_inf = IntegerOrInfinity::PositiveInfinity;
assert!(int_or_inf > int);
assert!(int < int_or_inf);

let int_or_inf = IntegerOrInfinity::NegativeInfinity;
assert!(int_or_inf < int);
assert!(int > int_or_inf);
}
}

0 comments on commit 628e31c

Please sign in to comment.