Game loop cleanup #245
Closed
Game loop cleanup #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch has been stale for a bit, so I want to review the changes before asking for review |
adam4813
commented
Aug 1, 2023
| @@ -203,7 +193,7 @@ eid PhysicsSystem::RayCastMousePick( | |||
| this->last_rayvalid = false; | |||
| this->last_entity_hit = 0; | |||
|
|
|||
| CollisionBody* body = static_cast<CollisionBody*>(body_iter->second->getUserPointer()); | |||
| auto* body = static_cast<CollisionBody*>(body_iter->second->getUserPointer()); | |||
There was a problem hiding this comment.
Suggestion from code quality tools to use auto since the name of the type is already on the initialization side.
adam4813
commented
Aug 1, 2023
| @@ -71,6 +71,8 @@ template <typename ID_T, typename T> class Multiton { | |||
| */ | |||
| static void Remove(const ID_T id) { instances.erase(id); } | |||
|
|
|||
| static const std::map<ID_T, T>& Instances() { return instances; } | |||
There was a problem hiding this comment.
Allows better iteration with range-based for loops
|
The last commit is just whitespace changes, so CI was skipped. I will bypass to merge, unless other changes are requested |
|
Moved to branch in this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang suggested code quality cleanups and general code quality cleanups from experience
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: