Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify client certificate path explicitly #29

Closed
dongwoo1005 opened this issue May 20, 2020 · 1 comment · Fixed by #31
Closed

Allow to specify client certificate path explicitly #29

dongwoo1005 opened this issue May 20, 2020 · 1 comment · Fixed by #31
Labels
enhancement New feature or request

Comments

@dongwoo1005
Copy link
Member

As per discussion in Slack: https://prestosql.slack.com/archives/CFPVDCDHV/p1589924393017200

Currently presto.dbapi.connect api does not have a parameter to explicitly specify client certificate path to connect with SSL/TLS. Client cert should be explicitly configurable.
@findepi findepi added the enhancement New feature or request label May 21, 2020
@findepi
Copy link
Member

findepi commented May 21, 2020

A current workaround, from referenced slack thread:

After creating the connection object I do

conn._http_session.verify = '/path/to/cert'

before creating a cursor.

caiopavanelli added a commit to s1mbi0se/presto-python-client that referenced this issue May 21, 2020
@caiopavanelli
Expose verify parameter on dbapi.connect
b3bdc48 
This resolves trinodb#29
@caiopavanelli caiopavanelli mentioned this issue May 21, 2020
Merged
electrum pushed a commit that referenced this issue Jun 26, 2020
@caiopavanelli @electrum
Expose verify parameter on dbapi.connect
836ed92 
This resolves #29
@findepi findepi mentioned this issue Oct 20, 2020
Closed
mvanderlee pushed a commit to mvanderlee/trino-python-client that referenced this issue Jan 15, 2021
@caiopavanelli @electrum
Expose verify parameter on dbapi.connect
f99e85b 
This resolves trinodb#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose verify parameter on dbapi.connect s1mbi0se/presto-python-client
2 participants
@findepi @dongwoo1005