Fixed MSVC warning about conditional expression being constant #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quuxplusone
added a commit
to Quuxplusone/uthash
that referenced
this pull request
May 14, 2024
MSVC `-W4` gives "warning C4127: conditional expression is constant" for `if (1 != 0)`, but no warning for `if (1)`. Use the latter instead of the former. In fact, the comparison against zero should really be all the way down in `HASH_BLOOM_BITTEST`. No functional change intended. Thanks to @noodlecollie for the patch!
|
@noodlecollie thanks! I merged a slightly different version that should fix the MSVC warning equally well. |
lonicerae
added a commit
to lonicerae/uthash
that referenced
this pull request
Sep 7, 2024
* Keep original design. This reverts commit 619fe95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the condition expands out to
1 != 0ifHASH_BLOOMis not defined. Instead, I've modified theHASH_BLOOM_TESTmacro to include the!= 0when the left hand side will not just be1, and leave the comparison as1otherwise - apparently MSVC thinksif ( 1 )is fine.