-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pairs from EVM chain tokelists.json #17637
Conversation
PR Summary |
PR Summary |
PR Summary |
d28bb47
to
c5d9ec2
Compare
PR Summary |
PR Summary |
PR Summary |
PR Summary |
internal/manager/commands.go
Outdated
@@ -72,6 +75,50 @@ var ( | |||
} | |||
}, | |||
} | |||
|
|||
addTokenlistCmd = &cobra.Command{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why duplicate addTokenlistCmd
and addTokenlistExtendedCmd
run command? it just a different file, create a function for it
internal/manager/helpers.go
Outdated
}) | ||
} | ||
|
||
func GetChainAndTokenID(token string) (string, coin.Coin, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function should exist in go-primitives
already
PR Summary |
PR Summary |
PR Summary |
PR Summary |
PR Summary |
PR Summary |
PR Summary |
PR Summary |
Closes #17642
Closes #17108