Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pairs from EVM chain tokelists.json #17637

Merged
merged 15 commits into from
Jan 27, 2022
Merged

Remove pairs from EVM chain tokelists.json #17637

merged 15 commits into from
Jan 27, 2022

Conversation

unanoc
Copy link
Contributor

@unanoc unanoc commented Jan 26, 2022

Closes #17642
Closes #17108

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 26, 2022

PR Summary
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 26, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 26, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 26, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 26, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

.github/assets.config.yaml Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 26, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

README.md Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 26, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@@ -72,6 +75,50 @@ var (
}
},
}

addTokenlistCmd = &cobra.Command{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why duplicate addTokenlistCmd and addTokenlistExtendedCmd run command? it just a different file, create a function for it

})
}

func GetChainAndTokenID(token string) (string, coin.Coin, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function should exist in go-primitives already

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 27, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
File internal/manager/helpers.go is being deleted. Files should not be deleted in a PR. (Deprecated tokens should be deactivated only.)
file is not allowed: internal/manager/manager.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 27, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
File internal/manager/helpers.go is being deleted. Files should not be deleted in a PR. (Deprecated tokens should be deactivated only.)
file is not allowed: internal/manager/manager.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 27, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
File internal/manager/helpers.go is being deleted. Files should not be deleted in a PR. (Deprecated tokens should be deactivated only.)
file is not allowed: internal/manager/manager.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 27, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
File internal/manager/helpers.go is being deleted. Files should not be deleted in a PR. (Deprecated tokens should be deactivated only.)
file is not allowed: internal/manager/manager.go: Please revert it.
file is not allowed: internal/processor/service.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 27, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
File internal/manager/helpers.go is being deleted. Files should not be deleted in a PR. (Deprecated tokens should be deactivated only.)
file is not allowed: internal/manager/manager.go: Please revert it.
file is not allowed: internal/processor/service.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 27, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
File internal/manager/helpers.go is being deleted. Files should not be deleted in a PR. (Deprecated tokens should be deactivated only.)
file is not allowed: internal/manager/manager.go: Please revert it.
file is not allowed: internal/processor/service.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 27, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
File internal/manager/helpers.go is being deleted. Files should not be deleted in a PR. (Deprecated tokens should be deactivated only.)
file is not allowed: internal/manager/manager.go: Please revert it.
file is not allowed: internal/processor/service.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jan 27, 2022

PR Summary
file is not allowed: .github/assets.config.yaml: Please revert it.
file is not allowed: Makefile: Please revert it.
file is not allowed: README.md: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/ethereum/tokenlist.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/polygon/tokenlist.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist-extended.json: Please revert it.
file is not allowed: blockchains/smartchain/tokenlist.json: Please revert it.
file is not allowed: go.mod: Please revert it.
file is not allowed: go.sum: Please revert it.
file is not allowed: internal/config/config.go: Please revert it.
file is not allowed: internal/manager/commands.go: Please revert it.
file is not allowed: internal/manager/helpers.go: Please revert it.
File internal/manager/helpers.go is being deleted. Files should not be deleted in a PR. (Deprecated tokens should be deactivated only.)
file is not allowed: internal/manager/manager.go: Please revert it.
file is not allowed: internal/processor/service.go: Please revert it.
file is not allowed: internal/processor/updaters_auto.go: Please revert it.

@vikmeup vikmeup merged commit ed272b2 into master Jan 27, 2022
@vikmeup vikmeup deleted the tokenlist-changes branch January 27, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokenlist changes Add a command for adding new tokens to tokenlists
2 participants