Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes an off-by-one error in kshape. (Issue #385) #417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

temcomp
Copy link

@temcomp temcomp commented Jul 26, 2022

Problem pointed out in issue #385. The original paper uses MATLAB-style indexing, i.e. starting on 1, as opposed to Python-style indexing starting on 0. Therefore there was a mismatch between tslearn and line 6, Algorithm 1 of that paper.

It should be noted that this indexing issue seems to be accounted for in this PR.

…s & Gravano uses MATLAB-style indexing on 1, instead of Python-style indexing on 0.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant