use same chromium path install method is invoked with for background install #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
merged commit e6b28bc
into
tsullivan:screenshotting/server-package-7.17
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Took a look at the test failures from elastic#189326, the most recent failure pointed out that the executable for linux was being requested from the wrong path, see image below;
I ran this fix, in https://buildkite.com/elastic/kibana-pull-request/builds/226872#0191380a-3ff3-49cb-ae34-73ee20eac596 and all tests pass besides the checks for console.log I had included to debug the value of the binary path in the eventuality of a failure which didn't happen.