Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Variable Playback Speed Feature #262

Closed
wants to merge 1 commit into from
Closed

Conversation

Dabuk
Copy link

@Dabuk Dabuk commented Feb 2, 2016

Added Playback Speed change feature with sliderUI in exampleApp.
Relevant comments written.

pcbeard added a commit to pcbeard/StreamingKit that referenced this pull request Mar 17, 2016
@pcbeard
Copy link
Contributor

pcbeard commented Mar 17, 2016

I cleaned this patch up a little bit and tested it:

https://github.com/pcbeard/StreamingKit/tree/PlaybackRate

It works, but if you set the audio rate to > 1for a network stream, the audio stops, because obviously it's not arriving at the rate it's being played.

@Dabuk
Copy link
Author

Dabuk commented Mar 17, 2016

What network streaming are you referencing to? Live streaming or a media link? If it's a media link it should work because streaming kit is deigned to pull more data off the stream as it is consumed. I have tested it for 2x..works fine..

@pcbeard
Copy link
Contributor

pcbeard commented Mar 17, 2016

Live streaming of course. There's no practical way to speed that up. Perhaps we should only selectively enable if the stream is able to read farther ahead?

@Sapanesh
Copy link

@pcbeard
Hi ,
I used your branch..but audio quality decreased after change playback rate.

Please suggest.

Thanks,

@anandmahajan
Copy link

Hi

@Dabuk @kevinrenskers

So quality really bad after change playback rate..Can you please help ?
Or any Solution ?

Thanks

mitchdowney pushed a commit to podverse/StreamingKit that referenced this pull request Jan 29, 2018
@QB3L
Copy link

QB3L commented Apr 3, 2018

I also tested this one and it works like a charm. @tumtumtum can we get it approved and merged?

@dong136279559
Copy link

I also need the function of rate. Could the author provide help
@tumtumtum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants