-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - Support Pydantic 2 and remove support for Pydantic V1 #70
Open
cgearing
wants to merge
12
commits into
main
Choose a base branch
from
feature/support-pydantic-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgearing
force-pushed
the
feature/support-pydantic-2
branch
from
August 11, 2024 14:13
664b414
to
a8c6f69
Compare
…t provide a response for a path, remove bypass logic
cgearing
force-pushed
the
feature/support-pydantic-2
branch
from
August 11, 2024 14:16
ab6158f
to
a749a3a
Compare
cgearing
force-pushed
the
feature/support-pydantic-2
branch
from
August 11, 2024 18:51
36187dc
to
c51a3f2
Compare
robyoung
reviewed
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Flask-Pydantic-Spec to only support Pydantic V2. After this PR is merged, only Pydantic V2 will be supported by Flask-Pydantic-Spec.
As part of this upgrade, we have decided to fully target OpenAPI 3.1 as the output of the library. As such, there are a few changes to keep in mind.
Flask-Pydantic-Spec
will now raise an error if there is no response defined for a view.[
and]
is not allowed in the name of the schema, so we will replace these character with_
.