Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsql-client-wasm: Fix bundled dependencies #168

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

penberg
Copy link
Contributor

@penberg penberg commented Jan 29, 2024

As it turns out, npm does not actually bundle dependencies if you're using workspace...

npm/cli#3466

Let's work around that by manually copying node_modules in pre-build step.

As it turns out, `npm` does not actually bundle dependencies if you're
using workspace...

npm/cli#3466

Let's work around that by manually copying `node_modules` in pre-build
step.
@penberg penberg merged commit bc542c5 into main Jan 29, 2024
3 checks passed
@penberg penberg deleted the fix-bundled-deps branch January 29, 2024 14:01
@d3lm
Copy link

d3lm commented Jan 29, 2024

Ay, what a bummer 🤦‍♂️

@d3lm
Copy link

d3lm commented Jan 29, 2024

Luckily, @libsql/libsql-wasm-experimental doesn't depend on any other dependencies so bundling this one is an easy one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants