Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage and tests cleanup #1

Closed
wants to merge 9 commits into from
Closed

Coverage and tests cleanup #1

wants to merge 9 commits into from

Conversation

tux-tn
Copy link
Owner

@tux-tn tux-tn commented Jul 11, 2020

  • Testing codecov automated coverage report

@codecov
Copy link

codecov bot commented Jul 11, 2020 •
edited
Loading

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           95        95           
  Lines         1243      1243           
=========================================
  Hits          1243      1243
Impacted Files Coverage Δ
src/lib/isSemVer.js 100.00% <ø> (ø)
src/lib/util/multilineRegex.js 100.00% <ø> (ø)
src/lib/isIdentityCard.js 100.00% <100.00%> (ø)
src/lib/isTaxID.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926accc...9704f16. Read the comment docs.

@tux-tn tux-tn mentioned this pull request Jul 11, 2020
Merged
@tux-tn tux-tn closed this Jul 14, 2020
tux-tn pushed a commit that referenced this pull request Aug 8, 2020
@stinkymonkeyph
feat(isMobilePhone): add support for Philippines locale (validatorjs#…
af36196 
…1388)

* Update isMobilePhone.js (#1)

Add support for Philippine mobile no.

* chore: add locale on readme

* refactor: remove en-PH validation for isMobilePhone

* feat: add Philippines mobile number validation

* feat: add test case for en-PH phone number

* chore: generate update

* refactor: add support for domestic ph numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tux-tn