Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@baseLineHeight and inputs with [span*] classes. #5127

Closed
maimairel opened this issue Sep 13, 2012 · 2 comments
Closed

@baseLineHeight and inputs with [span*] classes. #5127

maimairel opened this issue Sep 13, 2012 · 2 comments
Labels
Milestone

Comments

@maimairel
Copy link

When customizing Bootstrap with a different @baseLineHeight than the default one, then inputs inside row-fluid will have different heights compared to inputs in non row-fluid.

This is caused by .row-fluid [class*=span] defines min-height: 30px;

I think this can be fixed by computing the min-height for those inputs.

@maimairel
Copy link
Author

I recently discovered that this issue also happens on input-large, input-xlarge, input-xxlarge for viewports below 767px.

This is caused by the min-height: 30px; from mixins.less line 157:

// Block level inputs
.input-block-level {
display: block;
width: 100%;
min-height: 30px; <-- This should be computed from @baseLineHeight + padding + border
.box-sizing(border-box);
}

Also, select and input[type="file"]'s height and line height are also inconsistent with other inputs, as their height and line-height are 30px, not computed from @baseLineHeight.

Thank you

@maimairel
Copy link
Author

Thanks for the fix.

But this needs an additional fix which fixes the inputs for non-block level inputs.

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants