Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the opacity mixin be defined as a 0..1 range to match css? #6935

Closed
trisweb opened this issue Feb 14, 2013 · 7 comments
Closed

Should the opacity mixin be defined as a 0..1 range to match css? #6935

trisweb opened this issue Feb 14, 2013 · 7 comments
Labels
Milestone

Comments

@trisweb
Copy link

trisweb commented Feb 14, 2013

We've had a lot of trouble with this confusion (0..100 vs 0..1) at https://github.com/thomas-mcdonald/bootstrap-sass when people ask about conflicting mixins from compass and other libraries, and just general confusion with the mixin not matching the CSS attribute's standard range. We could change ours in the conversion to SASS, but we'd love to keep 1:1 compatibility with upstream with minimal customization to avoid inconsistencies.

On the off chance that it was simply never brought up—is there a reason this mixin uses 0..100 other than preference? Would it be feasible (or a good idea) to change it to match standard CSS?

@mdo
Copy link
Member

mdo commented Feb 14, 2013

We had done it this way as it was easier to convert for IE opacity. I'll check it out again for v3, but note that we have nothing to do with the Sass ports at this time.

@trisweb
Copy link
Author

trisweb commented Feb 14, 2013

Yep I know, I'm a committer on bootstrap-sass, so I'm asking on the behalf of the sass ports :)

Thanks for looking into it. In general I think matching the CSS would just be nice and proper.

@mdo
Copy link
Member

mdo commented Feb 14, 2013

Ah, didn't catch that :).

Are you guys the most popular Sass port here on GitHub? Curious who's all out there and what the landscape looks like as we'll be looking to don one as the official port in the coming months.

@trisweb
Copy link
Author

trisweb commented Feb 14, 2013

We're the most popular, but not the most pure. We optimize for the Rails and/or Compass toolchain and have integrations built in for both, so it's essentially a drop-in in those environments. Hence we're technically more popular, most likely due to the ease of integration.

A straight 1:1 port is https://github.com/jlong/sass-twitter-bootstrap - we actually collab with them and pull their translation directly, and can quickly do so for all upgrades with a build script. So they're effectively our upstream.

As an official sass port of bootstrap, sass-twitter-bootstrap gets my nod. As a rails/compass drop in, bootstrap-sass is the way to go. Your call.

@mdo
Copy link
Member

mdo commented Feb 14, 2013

Awesome, thanks for the lowdown, good sir. I'll look into that stuff more soon. <3

@mdo
Copy link
Member

mdo commented Mar 1, 2013

Fixed in v3—thanks!

@mdo mdo closed this as completed Mar 1, 2013
@trisweb
Copy link
Author

trisweb commented Mar 28, 2013

Awesome! Thank you so much.

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants