Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal's data-remote only changes modal body (not header or footer) #7149

Closed
kikito opened this issue Mar 4, 2013 · 1 comment
Closed

modal's data-remote only changes modal body (not header or footer) #7149

kikito opened this issue Mar 4, 2013 · 1 comment
Labels
js

Comments

@kikito
Copy link

kikito commented Mar 4, 2013

This was reported in #5161, but it seems that issue was closed by mistake.

Jsfiddle showing the issue:

http://jsfiddle.net/LEjAq/4/

Proposed fix: changing this line in bootstrap-modal.js:

 this.options.remote && this.$element.find('.modal-body').load(this.options.remote)

to this:

 this.options.remote && this.$element.load(this.options.remote)

That is all. Thank you.
@cvrebert cvrebert mentioned this issue Mar 4, 2013
Closed
alexhayes pushed a commit to alexhayes/bootstrap that referenced this issue Mar 22, 2013
Refs twbs#5161: Maintains backwards compatibility while allowing for …
3edf995 
…remote content that contains model header, body and footer.

Refs twbs#7149: Maintains backwards compatibility while allowing for remote content that contains model header, body and footer.
@fat
Copy link
Member

fat commented Jun 28, 2013

not closed by mistake

@fat fat closed this as completed Jun 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kikito @fat