Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion glitch #9552

Closed
JustinDrake opened this issue Aug 14, 2013 · 7 comments
Closed

Accordion glitch #9552

JustinDrake opened this issue Aug 14, 2013 · 7 comments
Labels
Milestone

Comments

@JustinDrake
Copy link

Chrome for Mac. Consider the example accordion in the docs. Each of the three collapsible panels has exactly the same content. Nevertheless, when successively clicking collapsible group 1, then collapsible group 2, group 3 moves a bit by a pixel or so; a subtle glitch.

@mdo
Copy link
Member

mdo commented Aug 14, 2013

Hmm, I don't see it on my end in Chrome for Mac.

@JustinDrake
Copy link
Author

Just checked again. It's a 1px thing, quite subtle. Chrome 28.0.1500.95.

@mdo
Copy link
Member

mdo commented Aug 14, 2013

I see the heading almost ghosting when expanding/collapsing, but that's it. Is that the movement you're seeing or is it actually increasing/decreasing the height? We do some slight border-fu when toggling, but it should all add up nicely.

@mdo mdo closed this as completed Aug 15, 2013
@mdo
Copy link
Member

mdo commented Aug 15, 2013

Doh, wrong issue.

@mdo mdo reopened this Aug 15, 2013
@JustinDrake
Copy link
Author

@mdo Observed on Chrome for Windows also.

@Merg1255
Copy link

add: the panels should be a few pixels closer to each other, same as with the original version of the plugin.

@mdo mdo closed this as completed in 82f6f08 Aug 17, 2013
@mdo
Copy link
Member

mdo commented Aug 17, 2013

Alright, I think I fixed the 1px issue, but my 👀 might just be bugging out at this point.

The problem was font-size: 17.5px which was being rounded inconsistently depending on where it fell in the over document flow. I reduced the font-size for aesthetic purposes and then rounded to the highest whole number.

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants