Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasis classes in navbar-text ignored #9947

Closed
jlaw90 opened this issue Aug 20, 2013 · 4 comments
Closed

Emphasis classes in navbar-text ignored #9947

jlaw90 opened this issue Aug 20, 2013 · 4 comments

Comments

@jlaw90
Copy link

jlaw90 commented Aug 20, 2013

See a jsFiddle example here: http://jsfiddle.net/h8XWv/

I'd assume that changing the ordering would fix this but as this change appears to have been made after RC1, it could well break something else.

EDIT: It seems to behave the same on navbar-default and navbar-inverse so perhaps it was when the styling was extracted from navbar that this change occured.

@fchiumeo
Copy link

this may help you #9806

@jlaw90
Copy link
Author

jlaw90 commented Aug 20, 2013

It looks like that wasn't the source of the problem unfortunately, after rolling back to the parent (9b66e6b) the problem still persists.

The problem seems to have been introduced in commit 9de7881, however navbar-inverse always had this issue it seems.

I'm not too sure how to fix this issue, I would normally use the extend feature of LESS but bootstrap is modular. I could duplicate the emphasis classes within a more specific selector in navbar.less, anyone got any better ideas?

@mdo
Copy link
Member

mdo commented Sep 5, 2013

Given the problem of selectors and collisions, I'd recommend just wrapping your content in another element and giving that the emphasis class. For example: http://jsfiddle.net/h8XWv/3/.

@mdo mdo closed this as completed Sep 5, 2013
mdo added a commit that referenced this issue Sep 5, 2013
@mdo
Copy link
Member

mdo commented Sep 5, 2013

Btw I added a callout to the docs to note this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants