Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Unicode space" from @breadcrumb-separator #10467

Closed
wants to merge 1 commit into from
Closed

Remove "Unicode space" from @breadcrumb-separator #10467

wants to merge 1 commit into from

Conversation

sirreal
Copy link

@sirreal sirreal commented Sep 5, 2013

The correct spacing around @breadcrumb-separator is achieved by li:before {padding: 0 5px;}.
Adding a space after the @breadcrumb-separator was causing the left side to be 5px and the right to be 5px + " ", making one side larger than the other.

Tested: OSX - Chrome / Firefox

The correct spacing around "@breadcrumb-separator" is achieved by the padding on the li:before content (0 5px). Adding a space to the content was causing irregular alignment in the breadcrumbs.

Tested: OSX - Chrome / Firefox
@mdo
Copy link
Member

mdo commented Sep 5, 2013

Looks fine to me in Chrome—the space is there, per the comment, to account for white-space behavior with inline-block elements.

@mdo mdo closed this Sep 5, 2013
@sirreal
Copy link
Author

sirreal commented Sep 6, 2013

I've looked at this some more and am surprised no one else is seeing it. Here's a screenshot from OSX Chrome v25.0.1364.160:
with_space
There is clearly more space to the right of the / That's with the latest vanilla bootstrap.

I've found a different solution which works in this version of Chrome that may shed some light on the issue. I have to change the space from "no break space" \00a0 to a space \0020 AND add display: inline-block to the &+li:before element. This achieves the same as removing the space from the content:
no_space

Here's the markup:

<ol class="breadcrumb col-sm-6">
    <li><a href="/index.php/main/index">Home</a></li><li><a href="/index.php/vat/index">Vats</a></li><li class="active">Create</li></ol>

@sirreal
Copy link
Author

sirreal commented Sep 6, 2013

I see the problem. Bootstrap expects space between the <li> in the markup, and adds space to the :before to compensate. My breadcrumbs are being generated with no spacing. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants