Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] fixed the horizontal form example #10471

Merged
merged 1 commit into from
Sep 5, 2013
Merged

Conversation

javiereguiluz
Copy link
Contributor

The original horizontal form example wasn't correctly displayed because it uses .col-lg- columns. Using .col-sm- columns fixes this problem:

form-horizontal

In addition, the id attributes of the form controls have been fixed (inputEmail3 instead of inputEmail1, etc.).

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 5, 2013

In that case, it should use .col-xs-*.

@javiereguiluz
Copy link
Contributor Author

@cvrebert I'm afraid that you cannot use .col-xs-* because the example uses column offsets and they aren't available for .col-xs-*

<input type="email" class="form-control" id="inputEmail1" placeholder="Email">
<label for="inputEmail3" class="col-sm-2 control-label">Email</label>
<div class="col-sm-10">
<input type="email" class="form-control" id="inputEmail3" placeholder="Email">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have changed the IDs of the inputs for no apparent reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. At the end of my commit I've added the following:

In addition, the id attributes of the form controls have been fixed (inputEmail3 instead of inputEmail1, etc.).

The reason? The first form example uses inputEmail1, the second example uses inputEmail2. Being the third example, I found it reasonable to rename it to inputEmail3 (the same goes for the password form field).

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 5, 2013

Ah, right, damn. We plan on remedying that, but not sure when.

cvrebert added a commit that referenced this pull request Sep 5, 2013
[doc] fixed the horizontal form example
@cvrebert cvrebert merged commit 8651180 into twbs:master Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants