Jumbotron: remove the hard-coded font-size from jumbotron.less and moved... #10949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved it into variables.less where other .font-size-xxxxx things now live.
|
Probably want to go with You'll also need to add the new variable to the Customizer page so folks can easily change it there. |
|
It's I count 9 instances of Good point about the customizer. |
…pClass}-font-size' naming scheme.
| @jumbotron-heading-color: inherit; | ||
| @font-size-jumbotron: ceil(@font-size-base * 1.50); |
There was a problem hiding this comment.
Still need to change the actual variable's name. :)
There was a problem hiding this comment.
Whoops, thank you. Good catch. I pushed the latest less/variables.less just now.
mdo
added a commit
that referenced
this pull request
Oct 14, 2013
Jumbotron: remove the hard-coded font-size from jumbotron.less and moved...
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
Jumbotron: remove the hard-coded font-size from jumbotron.less and moved...
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
Jumbotron: remove the hard-coded font-size from jumbotron.less and moved...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... it into variables.less where other .font-size-xxxxx things now live.