Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make .btn:focused styles apply to .btn.active:focused #12195

Merged
merged 1 commit into from
Feb 9, 2014
Merged

Conversation

cvrebert
Copy link
Collaborator

Proposed fix for #12154.
/to @mdo for review.

@mdo
Copy link
Member

mdo commented Jan 12, 2014

What about :active?

@cvrebert
Copy link
Collaborator Author

Hmm, I wasn't sure that :active:focus was a thing, but apparently it is. I'll update this accordingly.

@cvrebert
Copy link
Collaborator Author

@mdo Updated. Test bench: http://jsfiddle.net/n6Bc2/5/
Would be more elegant if we didn't have to contend with the outline: 0; on .btn:active, .btn.active.

@mdo
Copy link
Member

mdo commented Jan 13, 2014

Hmm, only other thing to think about is how this overlaps with dropdown buttons, button groups, and input groups. Currently we override the focus and outlines for those since the JS manually reapplies focus to the buttons when toggling content. The focus ring is seen as unattractive in those situations.

@mdo mdo mentioned this pull request Feb 9, 2014
1 task
@mdo mdo merged commit 4787a69 into master Feb 9, 2014
@mdo mdo deleted the fix-12154 branch February 9, 2014 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants